Re: [PATCH 2/2] iio: light: bh1730: Add bh1730 light sensor driver

[Andy Shevchenko]

On Mon, May 11, 2026 at 02:11:10AM +0700, Alexandre Hamamdjian wrote:

Please, do not top-post!

> Thank you Andy I will talk with Mr. CTCaer if he agrees to use his real
> name for this driver, as well as the others he wrote that I already
> submitted.

If not, you can use Originally-by tag.

> I am also taking note of your review and will soon test if using the common
> BH17 light sensor driver is better for our devices, I will follow up
> whenever possible.
> 
> Also awaiting for Mr. Vaittinen's review.

Yes, would be really nice to see Matti's review for this.

> On Mon, May 11, 2026, 1:20 AM Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> wrote:
> > On Sun, May 10, 2026 at 09:18:48PM +0300, Andy Shevchenko wrote:
> > > On Mon, May 11, 2026 at 01:09:50AM +0700, Alexandre Hamamdjian via B4
> > Relay wrote:

...

> > > Here I stop my review and recommend you first to review others' patches
> > and
> > > learn from other reviews. This will help you a lot with avoiding typical
> > > mistakes.
> > >
> > > Also Matti would be the best reviewer for this as he worked (still
> > works?)
> > > for ROHM and knows the HW a bit more than average kernel developer.
> >
> > Forgot to Cc Matti since I mentioned him. Now done.

-- 
With Best Regards,
Andy Shevchenko