Re: [PATCH] hwmon: corsair-psu: fix and readd locking of command buffer

[Guenter Roeck]

On 5/13/26 06:43, Guenter Roeck wrote:
> On 5/13/26 06:32, Wilken Gottwalt wrote:
> > Fix removed locking mechanism. The locking mechanism does protect
> > chained commands (set rail + get value), which are two separate calls
> > to the low level access function. The hwmon (temps for example) and
> > debugfs (uptimes for example) subsystem can trigger that chain of
> > commands in parallel. The serialization in the hw monioring core alone
> > is not enough.
> >
> > Fixes: 4207069edbf0 ("hwmon: (corsair-psu) Rely on subsystem locking")
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@xxxxxxxxxx>
>
> You'll need to explain why using the subsystem lock for debugfs
> accesses does not work.

Clarifying: "Why using hwmon_lock() / hwmon_unlock() in the debugfs functions
would be insufficient".

Guenter