Re: [PATCH 1/4] thermal/core: Add dedicated release callback for cooling devices

[Lukasz Luba]

Hi Daniel

On 5/8/26 19:05, Daniel Lezcano wrote:
> The thermal class release callback currently handles both thermal
> zones and cooling devices by checking the device name prefix.
>
> Move the cooling device cleanup to a dedicated struct device release
> callback.  This avoids relying on device names to select the release
> path and keeps the cooling device lifetime handling local to the
> cooling device object.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxxxxxxxx>
> ---
>   drivers/thermal/thermal_core.c | 19 +++++++++++--------
>   1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 2f4e2dc46b8f..cf5d4a9c11fe 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -952,7 +952,6 @@ static void thermal_unbind_cdev_from_trip(struct thermal_zone_device *tz,
>   static void thermal_release(struct device *dev)
>   {
>   	struct thermal_zone_device *tz;
> -	struct thermal_cooling_device *cdev;
>   
>   	if (!strncmp(dev_name(dev), "thermal_zone",
>   		     sizeof("thermal_zone") - 1)) {
> @@ -962,13 +961,6 @@ static void thermal_release(struct device *dev)
>   		ida_destroy(&tz->ida);
>   		mutex_destroy(&tz->lock);
>   		complete(&tz->removal);
> -	} else if (!strncmp(dev_name(dev), "cooling_device",
> -			    sizeof("cooling_device") - 1)) {
> -		cdev = to_cooling_device(dev);
> -		thermal_cooling_device_destroy_sysfs(cdev);
> -		kfree_const(cdev->type);
> -		ida_free(&thermal_cdev_ida, cdev->id);
> -		kfree(cdev);
>   	}
>   }
>   
> @@ -1040,6 +1032,16 @@ static void thermal_cooling_device_init_complete(struct thermal_cooling_device *
>   		thermal_zone_cdev_bind(tz, cdev);
>   }
>   
> +static void thermal_cdev_release(struct device *dev)
> +{
> +	struct thermal_cooling_device *cdev = to_cooling_device(dev);
> +
> +	thermal_cooling_device_destroy_sysfs(cdev);
> +	kfree_const(cdev->type);
> +	ida_free(&thermal_cdev_ida, cdev->id);
> +	kfree(cdev);
> +}
> +
>   /**
>    * __thermal_cooling_device_register() - register a new thermal cooling device
>    * @np:		a pointer to a device tree node.
> @@ -1093,6 +1095,7 @@ __thermal_cooling_device_register(struct device_node *np,
>   	cdev->ops = ops;
>   	cdev->updated = false;
>   	cdev->device.class = &thermal_class;
> +	cdev->device.release = thermal_cdev_release;
>   	cdev->devdata = devdata;
>   
>   	ret = cdev->ops->get_max_state(cdev, &cdev->max_state);

I hope it's not too late to the party...

This looks good, we avoid the problem we discussed earlier.

Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>

The whole patch set makes the things more clean.
It should be a good foundation for your next changes.
Thanks Daniel!

Regards,
Lukasz