Re: [PATCH v3] media: i2c: ov5645: Convert to CCI register access helpers

From: Lad, Prabhakar

Date: Fri May 15 2026 - 08:38:18 EST


Hi Sakari and Hans

On Mon, Mar 30, 2026 at 3:45 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
>
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Convert the ov5645 driver to use the V4L2 CCI register access helpers
> and regmap infrastructure instead of the custom I2C register access
> implementation.
>
> Keep ov5645_set_register_array() as ov5645_global_init_setting requires
> a delay between specific register writes, which cannot be expressed
> through the generic CCI multi-write helper.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Reviewed-by: Xiaolei Wang <Xiaolei.Wang@xxxxxxxxxxxxx>
> ---
> Note, this patch was originally part of series [0] since patch 1/2
> is no longer needed after patch [1] just sending this single patch.
>
> [0] https://lore.kernel.org/all/20260328132902.776757-1-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/
> [1] https://lore.kernel.org/all/20260329195625.2840728-1-sakari.ailus@xxxxxxxxxxxxxxx/
>
> v2->v3:
> - Made use of CCI_REG16 for the chip ID register
> - Replaced CHIP_ID_HIGH and CHIP_ID_LOW with a single
> CHIP_ID register definition
> - Added RB tag from Xiaolei Wang
>
> v1->v2
> - Fixed selecting V4L2_CCI_I2C config option for the OV5645 driver.
> - Fixed checkpatch warnings limiting to 80 characters per line.
> ---
> drivers/media/i2c/Kconfig | 1 +
> drivers/media/i2c/ov5645.c | 919 ++++++++++++++++++-------------------
> 2 files changed, 439 insertions(+), 481 deletions(-)
>
Gentle ping.

Cheers,
Prabhakar