Re: [PATCH 5/8] x86/msr: Switch rdmsr_safe_on_cpu() to return a 64-bit quantity

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> 
> * Juergen Gross <jgross@xxxxxxxx> wrote:
> 
> > In order to prepare retiring rdmsrq_safe_on_cpu() switch
> > rdmsr_safe_on_cpu() to have the same interface as rdmsrq_safe_on_cpu().
> 
> Patch #1.

Note that to do this, a new name should be introduced,
such as rdmsrq_safe_on_cpu() or so. This principle applies
to the other patches as well.

Ie. since we are changing the function signature anyway,
do not keep 32-bit API names, and introduce the new ones
cleanly in 3 patches:

  - introduce rdmsrq_safe_on_cpu()
  - change users from rdmsr_safe_on_cpu() => rdmsrq_safe_on_cpu()
  - remove obsolete rdmsr_safe_on_cpu()

This will make it easier to bisect any breakages, and will
make it easier to transition the APIs.

Thanks,

	Ingo