Re: [PATCH 8/8] x86/msr: Switch all callers of wrmsrq_safe_on_cpu() to use wrmsr_safe_on_cpu()

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> 
> * Juergen Gross <jgross@xxxxxxxx> wrote:
> 
> > Now that wrmsr_safe_on_cpu() has the same interface as
> > wrmsrq_safe_on_cpu(), the callers of wrmsrq_safe_on_cpu() can be
> > switched to wrmsr_safe_on_cpu() and wrmsrq_safe_on_cpu() can be
> > removed.
> > 
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > ---
> >  arch/x86/include/asm/msr.h                       |  5 -----
> >  arch/x86/kernel/acpi/cppc.c                      |  2 +-
> >  arch/x86/lib/msr-smp.c                           | 16 ----------------
> >  drivers/cpufreq/amd-pstate.c                     |  2 +-
> >  .../x86/intel/speed_select_if/isst_if_common.c   |  9 ++++-----
> >  5 files changed, 6 insertions(+), 28 deletions(-)
> 
> Please split this into two patches: one that does the API
> change only, and one that removes the now obsolete definitions.

Followup, instead of:

  x86/msr: Switch wrmsr_safe_on_cpu() to use a 64-bit quantity
  x86/msr: Switch all callers of wrmsrq_safe_on_cpu() to use wrmsr_safe_on_cpu()

Please just transition the users to the 64-bit API and remove the
unused 32-bit API:

  x86/msr: Switch all callers of wrmsr_safe_on_cpu() to use wrmsrq_safe_on_cpu()
  x86/mrs: Remove unused wrmsrq_safe_on_cpu() API

Thanks,

	Ingo