Re: [PATCH 0/1] ALSA: usb: Add support for Reloop Jockey 3 DJ controllers

[Takashi Iwai]

On Wed, 10 Jun 2026 00:16:42 +0200,
Frank van de Pol wrote:
> 
> 
> Hi Takashi, Hello ALSA community,
> 
> After being away from active ALSA development for some 25 years or so, I am 
> happy to submit this patch to introduce a dedicated driver supporting the 
> Jockey 3 series of DJ Controllers made by Reloop (specifically covering the 
> Master Edition and the Remix variants).
> 
> I initially evaluated the feasibility of integrating the required logic to 
> handle the non-standard proprietary Ploytec framing protocol into the standard 
> USB-audio driver via quirks. However, doing so would require introducing 
> numerous hardware-specific exceptions throughout the core layout, adding 
> significant complexity. A clean, isolated driver subdirectory provides much 
> better long-term maintainability without cluttering the existing class-compliant 
> architecture.
> 
> I have successfully validated and stress-tested this driver across three 
> distinct hardware architectures to ensure robustness regarding DMA, timing, 
> and memory alignment:
>  - x86_64 (Standard PC desktop environment)
>  - armhf (32-bit legacy environment on a Raspberry Pi 1B)
>  - arm64 (64-bit modern SoC environment on a Raspberry Pi 4)
> 
> I look forward to your review and feedback, and I am more than happy to 
> make architectural adjustments as required.
> 
> Best regards,
> Frank van de Pol

Hi Frank, nice to hear you again!

Through a quick glance, the driver design looks good and most of the
code are fine, but there can be small details that matter.  Could you
take a look at Sashiko review?
  https://sashiko.dev/#/patchset/20260609221643.3439698-2-fvdpol%40gmail.com

Not all items pointed there are useful, but the playback/capture
stream spinlock should be taken, and the use of the devres-memory for
URB buffer needs the re-consideration, too.

Last but not least, for the resubmission, please send to
linux-sound@xxxxxxxxxxxxxxx (and Cc to linux-kernel@xxxxxxxxxxxxxxx).
Recently we use alsa-devel ML only for user-space stuff, and the
kernel patches go to vger.


thanks,

Takashi