Re: [PATCH 0/1] ALSA: usb: Add support for Reloop Jockey 3 DJ controllers

[Frank van de Pol]

On Wed, Jun 10, 2026 at 09:48:58AM +0200, Takashi Iwai wrote:
> Hi Frank, nice to hear you again!
> 
> Through a quick glance, the driver design looks good and most of the
> code are fine, but there can be small details that matter.  Could you
> take a look at Sashiko review?
>   https://sashiko.dev/#/patchset/20260609221643.3439698-2-fvdpol%40gmail.com
> 
> Not all items pointed there are useful, but the playback/capture
> stream spinlock should be taken, and the use of the devres-memory for
> URB buffer needs the re-consideration, too.

Hi Takashi,

Thank you for your review.  

Great to hear that the architectural decision to make an isolated driver
over shoehorning this into the standard driver is accepted.  

I will have a look at the Sashiko review and pay extra attention to the
points you've highlighted.  

Hopefully I'll be able to submit version 2 of the patch by next week (after
completing the multi-platform validation).

> Last but not least, for the resubmission, please send to
> linux-sound@xxxxxxxxxxxxxxx (and Cc to linux-kernel@xxxxxxxxxxxxxxx).
> Recently we use alsa-devel ML only for user-space stuff, and the
> kernel patches go to vger.
> 

Thank you for pointing this out; I clearly missed that subtle yet important
detail.  Will keep learning :-)

Thanks,
Frank.