Re: [PATCH 1/2] dt-bindings: hwmon: pmbus: ti,lm25066: add current limit properties

[Potin Lai]

On Fri, Jun 12, 2026 at 1:27 AM Conor Dooley <conor@xxxxxxxxxx> wrote:
>
> On Thu, Jun 11, 2026 at 05:58:44PM +0800, Potin Lai wrote:
> > Add mutually exclusive 'ti,cl-smbus-high' and 'ti,cl-smbus-low' boolean
> > properties to configure the device's Current Limit (CL) behavior using
> > SMBus settings instead of physical pins.
> >
> > Signed-off-by: Potin Lai <potin.lai.pt@xxxxxxxxx>
> > ---
> >  .../devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml  | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml
> > index a20f140dc79a..95ea7c26dec2 100644
> > --- a/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml
> > @@ -46,6 +46,26 @@ properties:
> >
> >      additionalProperties: false
> >
> > +  ti,cl-smbus-high:
> > +    description: |
> > +      Configure the Current Limit (CL) to use the SMBus high setting.
> > +    type: boolean
> > +
> > +  ti,cl-smbus-low:
> > +    description: |
> > +      Configure the Current Limit (CL) to use the SMBus low setting.
> > +    type: boolean
>
> What's smbus specific about this? If the pin was connected to a GPIO,
> you'd then need to have different properties or use these ones with an
> inaccurate name.
>

The "smbus" in the property name was originally meant to indicate
that the setting is configured via the internal register over the SMBus (I2C)
interface, rather than physical pins.

> Please also spell out "current-limit".
>

I will rename the properties to "ti,current-limit-high" and
"ti,current-limit-low"
in the next version.

Thanks,
Potin

> pw-bot: changes-requested
>
> Thanks,
> Conor.
>
> > +
> > +dependencies:
> > +  ti,cl-smbus-high:
> > +    not:
> > +      required:
> > +        - ti,cl-smbus-low
> > +  ti,cl-smbus-low:
> > +    not:
> > +      required:
> > +        - ti,cl-smbus-high
> > +
> >  required:
> >    - compatible
> >    - reg
> >
> > --
> > 2.52.0
> >