Re: [PATCH 1/4] arm64: dts: qcom: pm4125: Add VADC and temp alarm nodes

[Dmitry Baryshkov]

On Sat, Jun 13, 2026 at 01:39:21PM +0530, Jishnu Prakash wrote:
> Add VADC node with some channels under it, for voltage and
> temperature readings. Add temperature alarm node, used for
> PMIC thermal mitigation.
> 
> Co-developed-by: Rakesh Kota <rakesh.kota@xxxxxxxxxxxxxxxx>
> Signed-off-by: Rakesh Kota <rakesh.kota@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/pm4125.dtsi | 77 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm4125.dtsi b/arch/arm64/boot/dts/qcom/pm4125.dtsi
> index 542e8fe030da..7113504d5941 100644
> --- a/arch/arm64/boot/dts/qcom/pm4125.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm4125.dtsi
> @@ -65,6 +65,83 @@ pm4125_typec: typec@1500 {
>  			status = "disabled";
>  		};
>  
> +		pm4125_tz: temp-alarm@2400 {
> +			compatible = "qcom,spmi-temp-alarm";
> +			reg = <0x2400>;
> +			interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_BOTH>;
> +			io-channels = <&pm4125_adc ADC5_DIE_TEMP>;
> +			io-channel-names = "thermal";
> +			#thermal-sensor-cells = <0>;
> +			status = "disabled";

Why would it be disabled by default?

> +		};
> +
> +		pm4125_adc: adc@3100 {
> +			compatible = "qcom,spmi-adc5";
> +			reg = <0x3100>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			#io-channel-cells = <1>;
> +			interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> +			status = "disabled";

Again, why?

> +
> +			/* Channel nodes */
> +			channel@0 {
> +				reg = <ADC5_REF_GND>;
> +				label = "ref_gnd";
> +				qcom,pre-scaling = <1 1>;
> +			};
> +
> +			channel@1 {
> +				reg = <ADC5_1P25VREF>;
> +				label = "vref_1p25";
> +				qcom,pre-scaling = <1 1>;
> +			};
> +
> +			channel@6 {
> +				reg = <ADC5_DIE_TEMP>;
> +				label = "die_temp";
> +				qcom,pre-scaling = <1 1>;
> +			};
> +
> +			channel@7 {
> +				reg = <ADC5_USB_IN_I>;
> +				label = "usb_in_i_uv";
> +				qcom,pre-scaling = <1 1>;
> +			};
> +
> +			channel@8 {
> +				reg = <ADC5_USB_IN_V_16>;
> +				label = "usb_in_v_div_16";
> +				qcom,pre-scaling = <1 16>;
> +			};
> +
> +			channel@9 {
> +				reg = <ADC5_CHG_TEMP>;
> +				label = "chg_temp";
> +				qcom,pre-scaling = <1 1>;
> +			};
> +
> +			channel@4b {
> +				reg = <ADC5_BAT_ID_100K_PU>;
> +				label = "bat_id";
> +				qcom,ratiometric;
> +				qcom,hw-settle-time = <200>;
> +				qcom,pre-scaling = <1 1>;
> +			};
> +
> +			channel@83 {
> +				reg = <ADC5_VPH_PWR>;
> +				label = "vph_pwr";
> +				qcom,pre-scaling = <1 3>;
> +			};
> +
> +			channel@84 {
> +				reg = <ADC5_VBAT_SNS>;
> +				label = "vbat_sns";
> +				qcom,pre-scaling = <1 3>;
> +			};
> +		};
> +
>  		rtc@6000 {
>  			compatible = "qcom,pm8941-rtc";
>  			reg = <0x6000>, <0x6100>;
> 
> -- 
> 2.43.0
> 

-- 
With best wishes
Dmitry