Re: [PATCH 1/2] staging: octeon: add missing tasklet_kill in cvm_oct_tx_shutdown

[Dan Carpenter]

On Sun, Jun 14, 2026 at 05:17:38PM +0530, Ayush Mukkanwar wrote:
> The TX cleanup tasklet can be scheduled by the watchdog IRQ handler
> to execute cvm_oct_tx_do_cleanup. There can be a pending tasklet in
> the queue which might run after the cvm_oct_remove() frees net_device
> structures, causing a use-after-free in cvm_oct_tx_do_cleanup() as it
> iterates cvm_oct_device[] which is an array of netdevice pointers.
> Add tasklet_kill() after free_irq() to ensure the tasklet is no longer
> scheduled or running before teardown proceeds.
> 
> Signed-off-by: Ayush Mukkanwar <ayushmukkanwar@xxxxxxxxx>
> ---

Looks good.  A couple process though.

1. It needs a Fixes tags.

2. You need to say when you are using AI.  I think you're supposed to
say which AI tool you are using as well.

3. You need to say that the patch has not been tested.

regards,
dan carpenter