RE: [Intel-wired-lan] [PATCH iwl-next v5 1/4] igc: remove unused autoneg_failed field

[Kwapulinski, Piotr]

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of KhaiWenTan
>Sent: Thursday, May 7, 2026 11:47 PM
>To: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; andrew+netdev@xxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx
>Cc: intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Abdul Rahim, Faizal <faizal.abdul.rahim@xxxxxxxxx>; Looi, Hong Aun <hong.aun.looi@xxxxxxxxx>; Blanco Alcaine, Hector <hector.blanco.alcaine@xxxxxxxxx>; Tan, Khai Wen <khai.wen.tan@xxxxxxxxx>; Faizal Rahim <faizal.abdul.rahim@xxxxxxxxxxxxxxx>; Loktionov, Aleksandr <aleksandr.loktionov@xxxxxxxxx>; Khai Wen Tan <khai.wen.tan@xxxxxxxxxxxxxxx>
>Subject: [Intel-wired-lan] [PATCH iwl-next v5 1/4] igc: remove unused autoneg_failed field
>
>From: Faizal Rahim <faizal.abdul.rahim@xxxxxxxxxxxxxxx>
>
>autoneg_failed in struct igc_mac_info is never set in the igc driver.
>Remove the field and the dead code checking it in igc_config_fc_after_link_up().
>
>The field originates from the e1000/e1000e fiber/serdes forced-link path, where MAC-level autoneg timeout sets it to signal the flow-control code to force pause. igc supports only copper, so it never needs to set this field.
>
>Reviewed-by: Looi Hong Aun <hong.aun.looi@xxxxxxxxx>
>Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>
>Signed-off-by: Faizal Rahim <faizal.abdul.rahim@xxxxxxxxxxxxxxx>
>Signed-off-by: Khai Wen Tan <khai.wen.tan@xxxxxxxxxxxxxxx>
>---
> drivers/net/ethernet/intel/igc/igc_hw.h  |  1 -  drivers/net/ethernet/intel/igc/igc_mac.c | 16 +---------------
> 2 files changed, 1 insertion(+), 16 deletions(-)
>
>diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ethernet/intel/igc/igc_hw.h
>index be8a49a86d09..86ab8f566f44 100644
>--- a/drivers/net/ethernet/intel/igc/igc_hw.h
>+++ b/drivers/net/ethernet/intel/igc/igc_hw.h
>@@ -92,7 +92,6 @@ struct igc_mac_info {
> 	bool asf_firmware_present;
> 	bool arc_subsystem_valid;
> 
>-	bool autoneg_failed;
> 	bool get_link_status;
> };
> 
>diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c
>index 7ac6637f8db7..142beb9ae557 100644
>--- a/drivers/net/ethernet/intel/igc/igc_mac.c
>+++ b/drivers/net/ethernet/intel/igc/igc_mac.c
>@@ -438,28 +438,14 @@ void igc_config_collision_dist(struct igc_hw *hw)
>  * Checks the status of auto-negotiation after link up to ensure that the
>  * speed and duplex were not forced.  If the link needed to be forced, then
>  * flow control needs to be forced also.  If auto-negotiation is enabled
>- * and did not fail, then we configure flow control based on our link
>- * partner.
>+ * then we configure flow control based on our link partner.
>  */
> s32 igc_config_fc_after_link_up(struct igc_hw *hw)  {
> 	u16 mii_status_reg, mii_nway_adv_reg, mii_nway_lp_ability_reg;
>-	struct igc_mac_info *mac = &hw->mac;
> 	u16 speed, duplex;
> 	s32 ret_val = 0;
> 
>-	/* Check for the case where we have fiber media and auto-neg failed
>-	 * so we had to force link.  In this case, we need to force the
>-	 * configuration of the MAC to match the "fc" parameter.
>-	 */
>-	if (mac->autoneg_failed)
>-		ret_val = igc_force_mac_fc(hw);
>-
>-	if (ret_val) {
>-		hw_dbg("Error forcing flow control settings\n");
>-		goto out;
>-	}
>-
> 	/* In auto-neg, we need to check and see if Auto-Neg has completed,
> 	 * and if so, how the PHY and link partner has flow control
> 	 * configured.
>--
>2.43.0

Reviewed-by: Piotr Kwapulinski <piotr.kwapulinski@xxxxxxxxx>