Re: [PATCH v3 4/4] phy: qcom: qmp-usbc: Add support for "phy" reset used on Shikra

[Krishna Kurapati]

On 5/27/2026 11:57 AM, Xiangxu Yin wrote:
> On 5/27/2026 2:44 AM, Pratham Pratap wrote:
> > From: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> >
> > Shikra uses three resets (dp/ phy/ phy_phy). Add the extra "phy" reset
> > needed for operation of QMP Phy on Shikra.
> >
> > Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Pratham Pratap <pratham.pratap@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
> > index c342479a3798..067e7f6e5642 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
> > @@ -513,7 +513,7 @@ static const char * const usb3phy_reset_l[] = {
> >   };
> >   
> >   static const char * const usb3dpphy_reset_l[] = {
> > -	"phy_phy", "dp_phy",
> > +	"phy_phy", "dp_phy", "phy",
> >   };
> >   
>
>
> usb3dpphy_reset_l is shared with qcs615_usb3dp_phy_cfg, but I didn't find any optional-reset handling in qmp_usbc_reset_init().
> talos.dtsi only defines two resets for qcom,qcs615-qmp-usb3-dp-phy, so adding "phy" here unconditionally will break probe on QCS615.
> Please create a separate reset list for Shikra instead.

ACK, will create a new match_data cfg for Shikra instead of reusing the 
talos one.

Regards,
Krishna,

> >   static const struct regulator_bulk_data qmp_phy_msm8998_vreg_l[] = {