Re: [PATCH 0/3] platform/x86/amd/hsmp: Harden ACPI probe, metric DRAM, and socket teardown

[Ilpo Järvinen]

On Tue, 16 Jun 2026, M K, Muralidhara wrote:

> Hi Ilpo,
> Could you please check and review.

Hi,

Please wait at least 2 weeks before inquiring about any series. And in 
any case, if the series is still listed in the platform drivers patchwork 
queue I'll eventually get to it (it won't be forgotten as long as it
appears in the patchwork).

In the meantime, you may want to check if sashiko.dev has found something 
that should be corrected. As sashiko is AI, it isn't always right so keep 
that in mind while reading it's findings. You don't need to address 
"pre-existing issue" reports sashiko gives nor defend against any of its 
findings unless a seasoned reviewer agrees with sashiko.

-- 
 i.

> On 6/14/2026 12:47 AM, Muralidhara M K wrote:
> > This series tightens concurrency and lifetime management in the ACPI-backed
> > AMD HSMP platform path so probe/remove races cannot corrupt global probe
> > state,
> > leak metric-table DRAM mappings, or tear down shared resources while readers
> > might still be active.
> > 
> > Patch 1 introduces a dedicated probe mutex around ACPI probe, remove, and
> > init_acpi(), replacing ad-hoc synchronization on the global is_probed
> > handshake.
> > lockdep_assert_held() documents the locking contract for init_acpi().
> > 
> > Patch 2 switches metric table DRAM from devm_ioremap() to ioremap() with
> > explicit init/teardown helpers, and embeds a per-socket mutex for metric
> > reads.
> > The legacy platform driver wires the same helpers so non-ACPI builds stay
> > consistent.
> > 
> > Patch 3 replaces the global is_probed flag with miscdevice registration
> > state,
> > refcounts ACPI socket platform devices with kref, and runs coordinated
> > release
> > on the final put: misc deregistration when appropriate, metric unmap, and
> > socket
> > array free. Socket storage uses kcalloc() with careful failure cleanup
> > before
> > any kref is published.
> > 
> > Muralidhara M K (3):
> >    platform/x86/amd/hsmp: Serialize ACPI HSMP is_probed with a probe
> >      mutex
> >    platform/x86/amd/hsmp: Add explicit metric DRAM mapping and per-socket
> >      mutexes
> >    platform/x86/amd/hsmp: ACPI HSMP refcounted sockets and coordinated
> >      release
> > 
> >   drivers/platform/x86/amd/hsmp/acpi.c | 87 +++++++++++++++++++++++-----
> >   drivers/platform/x86/amd/hsmp/hsmp.c | 38 +++++++++++-
> >   drivers/platform/x86/amd/hsmp/hsmp.h |  9 ++-
> >   drivers/platform/x86/amd/hsmp/plat.c |  3 +
> >   4 files changed, 119 insertions(+), 18 deletions(-)
> > 
>