Re: [PATCH] kgdb: remove unreachable return in kgdb_reenter_check()

[Doug Anderson]

Hi,

On Tue, Jun 16, 2026 at 9:43 AM Naveen Kumar Chaudhary
<naveen.osdev@xxxxxxxxx> wrote:
>
> Remove the dead 'return 1' after panic() in kgdb_reenter_check().
> panic() is marked __noreturn so the subsequent return statement can
> never execute.
>
> Signed-off-by: Naveen Kumar Chaudhary <naveen.osdev@xxxxxxxxx>
> ---
>  kernel/debug/debug_core.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
> index b276504c1c6b..1c9bc705c32c 100644
> --- a/kernel/debug/debug_core.c
> +++ b/kernel/debug/debug_core.c
> @@ -555,8 +555,6 @@ static int kgdb_reenter_check(struct kgdb_state *ks)
>  #endif
>         dump_stack();
>         panic("Recursive entry to debugger");
> -
> -       return 1;

I guess? I'm not terribly upset or confused by this extraneous
"return", but I guess it's fine to remove it...

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>