Re: [PATCH v3] net: mvneta: re-enable percpu interrupt on resume

[Zhou, Yun]

On 6/18/2026 11:53 PM, Sebastian Andrzej Siewior wrote:
> On 2026-06-18 23:45:51 [+0800], Zhou, Yun wrote:
> > > Having a NAPI instance with IRQ per queue and those configured and
> > > spread among CPUs should cause less trouble and is what others do.
> > > In fact is the only net driver using per-CPU interrupts.
> > It is a SoC limitation. Armada XP's MPIC provides a single shared
> > interrupt for the ethernet controller with per-CPU masking for
> > interrupt steering — there are no per-queue MSI vectors. The percpu
> > IRQ model was the only way to distribute interrupt handling across
> > CPUs given this hardware constraint.
>
> Is this a hardware constraint or more a software design choice? From the
> other comment it read like it could be changed.
> There is nothing wrong to provide 4 interrupts for a device from the
> device-tree and then allocate and request all four. This requires that
> SMP affinity is supported properly in order to spread it across CPU. You
> would also be able to reduce the amount of queues/ interrupts via
> ethtool if you would like to isolate a CPU for NOHZ reasons.
This is a hardware constraint, not a software design choice.

On MPIC platforms (armada-370/XP/38x), the mvneta interrupt (e.g.
hwirq 8) is a per-CPU hardware interrupt line (hwirq < 29 in MPIC).
It is a single physical interrupt source that MPIC routes to all CPUs
simultaneously — each CPU has its own per-CPU mask register to
independently control whether it responds to that same line.

There are not 4 separate hardware interrupt lines that could be
individually allocated. The irqchip driver (irq-armada-370-xp.c)
marks these hwirqs as IRQ_PER_CPU_DEVID in mpic_irq_map():

      if (mpic_is_percpu_irq(hwirq)) {
          irq_set_percpu_devid(virq);
          irq_set_chip_and_handler(virq, &mpic_irq_chip,
                                   handle_percpu_devid_irq);
      }

This means request_percpu_irq() is the only valid registration
method — a plain request_irq() would fail with -EINVAL because the
irq descriptor requires IRQ_PER_CPU_DEVID semantics.

The multi-interrupt approach (like MSI-X NICs) would require the
hardware to provide multiple distinct interrupt lines per port,
which this SoC does not have.

BR,
Yun