Re: [PATCH] iio: adc: ti-adc*: use dev_err_probe for probe time errors

From: Jonathan Cameron

Date: Tue Jun 23 2026 - 15:31:52 EST


On Thu, 18 Jun 2026 22:22:15 +0530
"Prashant Rahul" <prashantrahul23@xxxxxxxxx> wrote:

> On Tue Jun 16, 2026 at 7:33 PM IST, David Lechner wrote:
> > Please make one patch per file.
>
> will do
>
> > Please don't add new error messages. If there is a really good
> > reason to, please do that in a separate patch with a justification
> > as to why it is needed.
> > In this particular case, the only error is -ENOMEM, which we never
> > have an error message for.
>
> I understand. I will remove the additional logs, except the ones after
> `devm_iio_triggered_buffer_setup` for -ENOMEM.

This jumped out at me. We very rarely do special prints for anything
that returns -ENOMEM as that tends to be very noisy on the rare occasion
it happens. Note that dev_err_probe() doesn't print anything in this
case.

J