Re: [PATCH] iio: adc: ti-adc*: use dev_err_probe for probe time errors
From: Andy Shevchenko
Date: Tue Jun 23 2026 - 15:51:48 EST
On Tue, Jun 23, 2026 at 08:31:37PM +0100, Jonathan Cameron wrote:
> On Thu, 18 Jun 2026 22:22:15 +0530
> "Prashant Rahul" <prashantrahul23@xxxxxxxxx> wrote:
> > On Tue Jun 16, 2026 at 7:33 PM IST, David Lechner wrote:
...
> > I understand. I will remove the additional logs, except the ones after
> > `devm_iio_triggered_buffer_setup` for -ENOMEM.
>
> This jumped out at me. We very rarely do special prints for anything
> that returns -ENOMEM as that tends to be very noisy on the rare occasion
> it happens. Note that dev_err_probe() doesn't print anything in this
> case.
And I didn't check this as well, I though it might return more codes.
In such case this series is doomed because it adds dead code.
--
With Best Regards,
Andy Shevchenko