Re: [PATCH v3 1/2] iio: imu: inv_icm42600: reorder includes for buffer module
From: Andy Shevchenko
Date: Thu Jun 25 2026 - 02:57:45 EST
On Thu, Jun 25, 2026 at 09:56:01AM +0300, Andy Shevchenko wrote:
> On Thu, Jun 25, 2026 at 09:49:47AM +0300, Andy Shevchenko wrote:
> > On Wed, Jun 24, 2026 at 06:21:18PM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
> >
> > > Reorder includes following rules and delete unneeded kernel.h.
> >
> > Actually it's needed as 'proxy' header. If you want to get rid of it, it should
> > be another patch to replace that with the used headers following IWYU
> > principle.
> >
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>
> Also for the consistency's sake this should be done in all files in that
> folder. I see the same issue(s) in the _gyro and _accel and I assume the rest
> *.c and *.h also might be updated.
For the simplicity, just sort the each group of headers in all files. The IWYU
can be applied later on as it's not in the scope of your series.
--
With Best Regards,
Andy Shevchenko