Re: [PATCH v3 1/2] iio: imu: inv_icm42600: reorder includes for buffer module
From: Jean-Baptiste Maneyrol
Date: Thu Jun 25 2026 - 05:06:55 EST
>From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>Sent: Thursday, June 25, 2026 08:57
>To: Jean-Baptiste Maneyrol
>Cc: Jonathan Cameron; David Lechner; Nuno Sá; Andy Shevchenko; linux-iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v3 1/2] iio: imu: inv_icm42600: reorder includes for buffer module
>
>On Thu, Jun 25, 2026 at 09: 56: 01AM +0300, Andy Shevchenko wrote: > On Thu, Jun 25, 2026 at 09: 49: 47AM +0300, Andy Shevchenko wrote: > > On Wed, Jun 24, 2026 at 06: 21: 18PM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote: > > >
>ZjQcmQRYFpfptBannerStart
>This Message Is From an External Sender
>This message came from outside your organization.
>
>ZjQcmQRYFpfptBannerEnd
>
>On Thu, Jun 25, 2026 at 09:56:01AM +0300, Andy Shevchenko wrote:
>> On Thu, Jun 25, 2026 at 09:49:47AM +0300, Andy Shevchenko wrote:
>> > On Wed, Jun 24, 2026 at 06:21:18PM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
>> >
>> > > Reorder includes following rules and delete unneeded kernel.h.
>> >
>> > Actually it's needed as 'proxy' header. If you want to get rid of it, it should
>> > be another patch to replace that with the used headers following IWYU
>> > principle.
>> >
>> > Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>>
>> Also for the consistency's sake this should be done in all files in that
>> folder. I see the same issue(s) in the _gyro and _accel and I assume the rest
>> *.c and *.h also might be updated.
>
>For the simplicity, just sort the each group of headers in all files. The IWYU
>can be applied later on as it's not in the scope of your series.
>
>--
>With Best Regards,
>Andy Shevchenko
>
Hello Andy,
no problem, I will do that in the next version.
Thanks,
JB