Re: [PATCH v2 1/2] dt-bindings: power: supply: Add TI BQ25630 charger

[Waqar Hameed]

On Mon, Jun 22, 2026 at 13:06 +0200 Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> On Thu, Jun 18, 2026 at 03:37:59PM +0200, Waqar Hameed wrote:
>> +allOf:
>> +  - $ref: power-supply.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: ti,bq25630
>> +
>> +  reg:
>> +    const: 0x6b
>> +    description:
>> +      Device I2C address.
>
> Drop description, obvious.

I see that several others actually don't have a description for this
property. I'll drop it!

>
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +    description: |
>
> Do not need '|' unless you need to preserve formatting.

Right, let's remove it.

>
>> +      Device sends active low 256 µs pulse. Type should therefore be
>> +      IRQ_TYPE_EDGE_FALLING.
>> +
>> +  monitored-battery: true
>
> Drop this one

I was actually unsure about this one, but several other bindings had
this one. We can remove it.

>
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - monitored-battery
>> +
>> +additionalProperties: false
>
> And here use 'unevaluatedProperties: false' instead.

Hm, reading the documentation [1], `unevaluatedProperties` should be
used, because of the "include" of `power-supply.yaml`. I'll change to
that.

However, there are tons of other places where `additionalProperties` is
used instead _with_ a reference to `power-supply.yaml` (which is what I
followed). Are all of them actually "wrong" then?

>
> With these fixed:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Thank you for your review Krzysztof!

[1] `Documentation/devicetree/bindings/writing-schema.rst`