Re: [PATCH v2 1/2] dt-bindings: power: supply: Add TI BQ25630 charger

[Krzysztof Kozlowski]

On 25/06/2026 13:27, Waqar Hameed wrote:
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - interrupts
>>> +  - monitored-battery
>>> +
>>> +additionalProperties: false
>>
>> And here use 'unevaluatedProperties: false' instead.
> 
> Hm, reading the documentation [1], `unevaluatedProperties` should be
> used, because of the "include" of `power-supply.yaml`. I'll change to
> that.
> 
> However, there are tons of other places where `additionalProperties` is
> used instead _with_ a reference to `power-supply.yaml` (which is what I
> followed). Are all of them actually "wrong" then?

No, they are not wrong, but usually preferred is to allow all properties
from referenced power-supply schema.

Best regards,
Krzysztof