Re: [PATCH v2 1/2] dt-bindings: power: supply: Add TI BQ25630 charger

[Waqar Hameed]

On Thu, Jun 25, 2026 at 14:10 +0200 Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> On 25/06/2026 13:27, Waqar Hameed wrote:
>>>> +
>>>> +required:
>>>> +  - compatible
>>>> +  - reg
>>>> +  - interrupts
>>>> +  - monitored-battery
>>>> +
>>>> +additionalProperties: false
>>>
>>> And here use 'unevaluatedProperties: false' instead.
>> 
>> Hm, reading the documentation [1], `unevaluatedProperties` should be
>> used, because of the "include" of `power-supply.yaml`. I'll change to
>> that.
>> 
>> However, there are tons of other places where `additionalProperties` is
>> used instead _with_ a reference to `power-supply.yaml` (which is what I
>> followed). Are all of them actually "wrong" then?
>
> No, they are not wrong, but usually preferred is to allow all properties
> from referenced power-supply schema.

Ah ok, I can see why it's more preferable to be more "permissive" with
`unevaluatedProperties`. Thanks!