Re: [PATCH] cpufreq: tegra124: Disable DFLL clock on removal

From: Jon Hunter

Date: Fri Jun 26 2026 - 13:19:11 EST




On 26/06/2026 10:30, Myeonghun Pak wrote:
tegra124_cpu_switch_to_dfll() enables the DFLL clock before switching
the CPU clock parent to it. If cpufreq_dt_pdev_register() fails after
that point, or when the driver is removed, the driver only drops clock
references and never disables the enabled DFLL clock.

So after this change, if we successful switch to the DFLL, but we fail to register the device, we disable the DFLL. That does not sound good because the CPU will be using that clock at the time. I am not sure what the value in this change really is.

Jon

--
nvpublic