Re: [PATCH] drm/amd/display: Remove redundant NULL check before kfree() in mod_power_create()
From: Ziran Zhang
Date: Sat Jun 27 2026 - 05:57:41 EST
On Sat, 27 Jun 2026 11:43:25 +0200, Markus Elfring wrote:
> …
> > +++ b/drivers/gpu/drm/amd/display/modules/power/power.c
> > @@ -270,12 +270,10 @@ struct mod_power *mod_power_create(struct dc *dc,
> > fail_bad_brightness_range:
> …
> > fail_construct:
> > for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) {
> > - if (core_power->map[i].psr_context)
> > - kfree(core_power->map[i].psr_context);
> > + kfree(core_power->map[i].psr_context);
> > }
> May curly brackets be omitted here?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.1#n197
>
> Regards,
> Markus
Yes, you're right. I will send a v2 with this fixed.
Regards,
Ziran Zhang