RE: [External Mail] Re: [PATCH v3 2/7] net: wwan: t9xx: Add control plane transaction layer

[Wu. JackBB (GSM)]

Hi Andrew,

> > +static int __init mtk_common_drv_init(void)
> > +{
> > +	return 0;
> > +}
> > +module_init(mtk_common_drv_init);
> > +
> > +static void __exit mtk_common_drv_exit(void)
> > +{
> > +}
> > +module_exit(mtk_common_drv_exit);
>
> Since these don't do anything, they should not be needed.

Will move module_init/module_exit to the patch that first adds
content to them in v4.

> > +	SET_HW_BITS(hw_bits, chs, MHCCIF_RC2EP_EVT_DEVICE_RESET,
> > +		    DEV_EVT_H2D_DEVICE_RESET);
> > +
> > +	return LE32_TO_U32(cpu_to_le32(hw_bits));
>
> Please don't add white space like this. I assume a previous patch
> added this code, so move this to that patch.

Will remove the extra blank line in v4.

> > -	devm_kfree(dev, mdev);
> > +	mtk_dev_free(mdev);
>
> Why are you removing devm_ calls?

mtk_dev_alloc/mtk_dev_free are paired wrappers so the caller
doesn't need to know the underlying allocation mechanism.
The devm_kfree is still called inside mtk_dev_free.

Thanks.

Jack Wu.