Re: [PATCH 0/2] Add APSS clock driver support for IPQ5210

[Krzysztof Kozlowski]

On 30/06/2026 09:27, Varadarajan Narayanan wrote:
> On Mon, Jun 29, 2026 at 09:30:11AM +0200, Krzysztof Kozlowski wrote:
>> On Mon, Jun 29, 2026 at 10:08:41AM +0530, Varadarajan Narayanan wrote:
>>> IPQ5210 uses the HUAYRA pll for the APSS clock. This series adds support
>>> for the APSS clock to change the CPU frequency to one of the supported
>>> frequencies.
>>>
>>> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@xxxxxxxxxxxxxxxx>
>>> ---
>>> Varadarajan Narayanan (2):
>>>       dt-bindings: clock: qcom,a53pll: Add IPQ5210 compatible
>>>       clk: qcom: apss-ipq-pll: Add IPQ5210 support
>>>
>>>  .../devicetree/bindings/clock/qcom,a53pll.yaml        |  1 +
>>>  drivers/clk/qcom/apss-ipq-pll.c                       | 19 +++++++++++++++++++
>>>  2 files changed, 20 insertions(+)
>>> ---
>>> base-commit: 533704f3c28c3f5f9e2542aa3a6a326c32e6f5c0
>>> change-id: 20260625-apss-clk-ed39c40ed468
>>> prerequisite-change-id: 20260515-tsens-802eef7a2cf6:v1
>>> prerequisite-patch-id: 55c7e7f58ff80ecfed956707a9a893bbf59ef74b
>>
>> Really, how?
> 
> This patch is part of the series that enables cpufreq on ipq5210 that
> enables APSS pll, then enables the mailbox, and finally the cpufreq
> driver. While testing the cpufreq + thermal sensor throttling, needed

This is not what is expressed here. You wrote in cover letter
dependencies needed to build or apply this patchset.

By including random or irrelevant dependencies you only make review more
difficult (because I might need to consider now the dependency in this
patch) or introduce unnecessary obstacles for merging.


Best regards,
Krzysztof