RE: [PATCH 2/6] hwmon: (pmbus/max20830): add support for enable GPIO

[Torreno, Alexis Czezar]

> > +	enable_gpio = devm_gpiod_get_optional(&client->dev, "enable",
> GPIOD_OUT_HIGH);
> > +	if (IS_ERR(enable_gpio))
> > +		return dev_err_probe(&client->dev, PTR_ERR(enable_gpio),
> > +				     "Failed to get enable GPIO\n");
> > +
> 
> The above code gets the gpio reference, and then it doesn't do anything with it.
> What exactly is the point of this exercise ? Where is the chip actually enabled ?
> 
> Do you have an actual customer with such a set-up or is this "just in case" ?
> Have you tested this code to ensure that the chip is actually enabled in this
> setup ?
> 
> If there is indeed a use case where a customer indeed connects the enable pin
> to a gpio output, wouldn't that same customer also want to connect the
> "pgood" output to a gpio pin ? And what about the LDOIN pin ? Shouldn't that
> be connected to a power supply ?
> 

You're right. I initially just wanted to add the enable pin in the bindings, I might've
thought I need to do something to the driver code too. Which is unnecessary...
I will be removing this patch 2/6.

Regards,
Alexis