Re: [PATCH] platform/x86: dell-wmi-sysman: Don't hex dump attribute security buffer

From: Ilpo Järvinen

Date: Wed Jul 01 2026 - 07:35:52 EST


On Sun, 14 Jun 2026 13:53:53 +0900, HyeongJun An wrote:

> set_attribute() populates the security area of the BIOS attribute request
> buffer with the current admin password via populate_security_buffer(), then
> dumps the whole request buffer with print_hex_dump_bytes(). This can expose
> the plaintext admin password in the kernel log.
>
> The same issue was fixed for the password attribute path by
> commit d1a196e0a6dc ("platform/x86: dell-wmi-sysman: Don't hex dump
> plaintext password data"). Remove the remaining dump from the BIOS
> attribute path.
>
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent or clearly a regression fix.

The list of commits applied:
[1/1] platform/x86: dell-wmi-sysman: Don't hex dump attribute security buffer
commit: 0df706e5e724418283233cd02fff2e7afc682776

--
i.