Re: [PATCH] platform/x86: hp-wmi: Add fan control support for OMEN 8C4D

[Ilpo Järvinen]

On Tue, 16 Jun 2026, Lauri Sarap wrote:

> The HP OMEN Transcend 16-u1xxx with board ID 8C4D uses the
> Victus S fan control path with OMEN v1 thermal profile parameters.
> 
> Manual fan control has been tested through the hwmon pwm interface. The
> legacy OMEN profile path exposes controls but does not change fan speed
> on this board; the Victus S table with omen_v1_thermal_params provides
> working fan RPM changes.
> 
> Assisted-by: Codex:GPT-5
> Signed-off-by: Lauri Sarap <lauri.aardla@xxxxxxxxx>
> ---
>  drivers/platform/x86/hp/hp-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index d1cc6e7d1..ffe229ec0 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -221,6 +221,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BD5") },
>  		.driver_data = (void *)&victus_s_thermal_params,
>  	},
> +	{
> +		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8C4D") },
> +		.driver_data = (void *)&omen_v1_thermal_params,
> +	},
>  	{
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8C76") },
>  		.driver_data = (void *)&omen_v1_thermal_params,

Thanks for the patch.

hp-wmi driver's .driver_data scope has been expanded. Please check the 
very changes recently added into the review-ilpo-next branch in the 
platform drivers repo and adapt this patch accordingly. Then post v2, 
thank you.

-- 
 i.