Re: [PATCH v7 1/7] dt-bindings: clock: qcom: Move glymur TCSR to own binding

[Krzysztof Kozlowski]

On 03/07/2026 14:16, Qiang Yu wrote:
> On Fri, Jul 03, 2026 at 07:58:00AM +0200, Krzysztof Kozlowski wrote:
>> On Thu, Jul 02, 2026 at 12:36:11AM -0700, Qiang Yu wrote:
>>> The QREF block supplies reference clocks to PCIe PHYs and requires
>>> dedicated LDO supplies to operate. The digital control interface for QREF
>>> (clkref_en registers) resides in TCSR on glymur. Since QREF has no
>>> dedicated DT node of its own, these supply properties are placed in the
>>> TCSR node which acts as the control interface for QREF.
>>>
>>> Add a dedicated binding file for qcom,glymur-tcsr and document the supply
>>> properties. As this binding will grow to cover more SoCs, mark the
>>> required supplies per compatible using an allOf/if/then conditional.
>>>
>>> Signed-off-by: Qiang Yu <qiang.yu@xxxxxxxxxxxxxxxx>
>>
>> So you dropped the tag because? Where is the explanation?
>>
> Sorry for the confusion. The patch was substantially reworked in v7
> based on your v6 review comments on patch 2: the compatible was changed
> from const to an enum, and the allOf/if/then block was moved into this
> patch upfront. Since the diff changed significantly from what you
> reviewed, I dropped the tag rather than carry it forward silently.

Dropping tag is fine, but what do the submitting patches say when you
drop someone's tag?

Best regards,
Krzysztof