Re: [PATCH RFC 2/6] ASoC: qcom: sdm845: use DSP_A format for TDM codec DAIs
From: Konrad Dybcio
Date: Mon Jul 06 2026 - 06:50:32 EST
On 7/6/26 11:15 AM, David Heidelberg wrote:
> On 06/07/2026 10:33, Konrad Dybcio wrote:
>> On 7/5/26 10:06 PM, David Heidelberg via B4 Relay wrote:
>>> From: David Heidelberg <david@xxxxxxx>
>>>
>>> Before the DSP_B only worked because the only close-to-mainline consumer
>>> cs35l36 codec was patched to map both DSP_A and DSP_B to the same
>>> hardware register value (asp_fmt = 0), which is inherently DSP_A timing.
>>> Use the right codec (DSP_A) which works as expected.
>>>
>>> Signed-off-by: David Heidelberg <david@xxxxxxx>
>>> ---
>>
>> Fixes?
>>
>
> I was thinking about it, but I don't see any mainline consumer of TDM within the sdm845 arch.
>
> If you think it make sense, I'll mark it.
I personally think Fixes makes sense whenever the code is fixed,
not only if there's a user-visible bug. Up to you.
Konrad