[PATCH v1] platform/surface: surfacepro3_button: Stop setting acpi_device_name()
From: Rafael J. Wysocki
Date: Mon Jul 06 2026 - 08:29:10 EST
From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Since acpi_device_name() set by the driver is only used for input
class device name initialization and printing a message on probe
success, and SURFACE_BUTTON_DEVICE_NAME can be used instead of it
directly in both cases, make the driver do so and stop setting
acpi_device_name().
No intentional functional impact.
This will facilitate the removal of device_name from struct
acpi_device_pnp in the future.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---
drivers/platform/surface/surfacepro3_button.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- a/drivers/platform/surface/surfacepro3_button.c
+++ b/drivers/platform/surface/surfacepro3_button.c
@@ -212,11 +212,10 @@ static int surface_button_probe(struct p
goto err_free_button;
}
- strscpy(acpi_device_name(device), SURFACE_BUTTON_DEVICE_NAME);
snprintf(button->phys, sizeof(button->phys), "%s/buttons",
acpi_device_hid(device));
- input->name = acpi_device_name(device);
+ input->name = SURFACE_BUTTON_DEVICE_NAME;
input->phys = button->phys;
input->id.bustype = BUS_HOST;
input->dev.parent = &pdev->dev;
@@ -239,7 +238,7 @@ static int surface_button_probe(struct p
goto err_free_button;
}
- dev_info(&pdev->dev, "%s [%s]\n", acpi_device_name(device),
+ dev_info(&pdev->dev, SURFACE_BUTTON_DEVICE_NAME " [%s]\n",
acpi_device_bid(device));
return 0;