Re: [PATCH v1] platform/surface: surfacepro3_button: Stop setting acpi_device_name()

From: Chen, Yu C

Date: Mon Jul 06 2026 - 13:42:44 EST


On 7/6/2026 8:28 PM, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Since acpi_device_name() set by the driver is only used for input
class device name initialization and printing a message on probe
success, and SURFACE_BUTTON_DEVICE_NAME can be used instead of it
directly in both cases, make the driver do so and stop setting
acpi_device_name().

No intentional functional impact.

This will facilitate the removal of device_name from struct
acpi_device_pnp in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---

I have not noticed any issues,
(sashiko reported an invalid and unrelated to this patch race of UAF,
which should be gated by evdev->mutex)

Reviewed-by: Chen Yu <yu.c.chen@xxxxxxxxx>

thanks,
Chenyu