RE: [PATCH char-misc v2] mei: lb: fix incorrect type in assignment

From: Usyskin, Alexander

Date: Tue Jul 07 2026 - 02:48:21 EST


> Subject: Re: [PATCH char-misc v2] mei: lb: fix incorrect type in assignment
>
> On Mon, Jul 06, 2026 at 04:01:30PM +0300, Alexander Usyskin wrote:
> > Fix the mix between __le32 and integer by casting
> > the MEI_LB2_CMD constant as __le32 while using it.
> >
> > Fixes sparse waring:
> > drivers/misc/mei/mei_lb.c:284:32: sparse: sparse: restricted __le32
> degrades to integer
> > drivers/misc/mei/mei_lb.c:330:40: sparse: sparse: incorrect type in
> assignment (different base types) @@ expected restricted __le32 [usertype]
> command_id @@ got int @@
> > drivers/misc/mei/mei_lb.c:330:40: sparse: expected restricted __le32
> [usertype] command_id
> > drivers/misc/mei/mei_lb.c:330:40: sparse: got int
> >
> > Cc: stable@xxxxxxxxxxxxxxx
>
> Why cc: stable? It doesn't actually cause any functional change to the
> code at all, right? This isn't running on s390, or am I mistaken?
>

This driver is for discrete graphics card, so it may run on non-x86 system, thus all conversions.

I've been told that if there is Fixes: for commit that already in stable, I should cc: stable.
If it is not hard rule, I'll drop cc: from the next patch revision.

- -
Thanks,
Sasha