Re: [PATCH 3/9] dt-bindings: PCI: Add bindings for endpoint gpios

[Manivannan Sadhasivam]

On Wed, Jul 01, 2026 at 12:32:45AM +0530, Sushrut Shree Trivedi wrote:

Use proper prefix for the subject.

> Add devicetree bindings for TC9563 GPIO's which are
> used to control endpoint power and reset.
> 
> Signed-off-by: Sushrut Shree Trivedi <sushrut.trivedi@xxxxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/pci/toshiba,tc9563.yaml    | 22 +++++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml b/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> index b3ad05d90201..f9f71f28aa92 100644
> --- a/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> +++ b/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> @@ -26,6 +26,11 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +        const: 2

Fix indent.

> +
>    resx-gpios:
>      maxItems: 1
>      description:
> @@ -69,6 +74,17 @@ $defs:
>      type: object
>  
>      properties:
> +      reset-gpios:
> +        description:
> +          Specify the TC9563 GPIO used to reset the endpoint
> +          connected to the particular TC9563 downstream port.
> +

This the PERST# signal, isn't it? If so, mention it as-is.

> +      ep-pwr-en-gpios:
> +        description:
> +          Specify the TC9563 GPIO used for enabling power to
> +          the endpoint connected to the particular TC9563
> +          downstream port.
> +

So this GPIO controls 3.3v supply to the endpoint? If so, it should be described
as a GPIO controlled regulator:

	vreg_pcie_3v3: regulator-pcie-3v3 {
		compatible = "regulator-fixed";		
		...
		gpio = <&tc9563 2 GPIO_ACTIVE_HIGH>;
		...
	};

And then you should let the pwrctrl driver control the upstream port. The upside
here is that the pwrctrl driver already controls both 3.3v and reset-gpios
(PERST#). So you do not need to have any change in the TC9563 driver.

- Mani

-- 
மணிவண்ணன் சதாசிவம்