Re: [PATCH v3 4/4] arm64: dts: qcom: Fix pm4125 vbus regulator compatible and constraints

[Krzysztof Kozlowski]

On 07/07/2026 10:33, Rakesh Kota wrote:
> On Mon, Jul 06, 2026 at 02:49:33PM +0100, Bryan O'Donoghue wrote:
>> On 06/07/2026 13:31, Rakesh Kota wrote:
>>> Remove pm8150b fallback compatible from pm4125_vbus and fix regulator
>>> constraints in qrb2210 DTS files to use microvolt instead of
>>> microamp.
>>>
>>> Signed-off-by: Rakesh Kota <rakesh.kota@xxxxxxxxxxxxxxxx>
>> You should break this patch up at the "and"
>>
>> One to remove the fallabck, one to fixup your regulator stuff.
>>
> I understand the preference for splitting at the "and", however
> splitting this patch is not straightforward in this case. The PM4125

Yes. This is one logical change - fix the node to properly match
hardware and bindings. The compatible is tied to properties
(constraints). Splitting the patch would mean you want to keep old
compatible with new constraints which would be wrong.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof