Re: [PATCH v1 2/2] arm64: dts: qcom: eliza-cqs-evk: Enable sound card support with WSA8845 and DMIC

[Konrad Dybcio]

On 7/1/26 7:43 PM, Ravi Hothi wrote:
> Enable the sound card on the Eliza CQS EVK platform, including the
> WSA8845 external speaker path and DMIC microphone capture via VA macro.
>
> Enable the required LPASS WSA macro, VA macro and SoundWire controller
> along with the necessary pinctrl configurations for DMIC and WSA
> SoundWire interfaces.
>
> Signed-off-by: Ravi Hothi <ravi.hothi@xxxxxxxxxxxxxxxx>
> ---

[...]

> +&lpass_vamacro {
> +	status = "okay";

'status' should be the last property (let's also keep an \n before
it) - file-wide

[...]

> +&pm7550_gpios {
> +	dmic-eldo-en-hog {
> +		gpio-hog;
> +		gpios = <7 GPIO_ACTIVE_HIGH>;
> +		output-high;
> +		line-name = "dmic-eldo-en";
> +	};

Why add a hog if you defined the regulator already?

Konrad