Re: [PATCH v5 02/10] x86/topology: Export topo_lookup_cpuid() for resctrl use

From: Reinette Chatre

Date: Fri Jul 10 2026 - 19:35:40 EST


Hi Chenyu,

Since this targets a different subsystem, could you please re-order the series
to have this as first patch to make it obvious that it does not depend on
anything in this series.

On 7/1/26 6:45 AM, Chen Yu wrote:
> Make topo_lookup_cpuid() accessible outside of topology.c and add its
> declaration to asm/apic.h. This is needed by Enhanced RDT (ERDT) to
> resolve x2APIC IDs from ACPI tables to logical CPU numbers.

The first sentence of this changelog describes verbatim what can clearly
be seen from the patch self without any context or problem description about
why this change is needed.
tip changelogs always need to start with *why* the patch is needed before
describing the change self. For more details about changelog requirements, please
see "Changelog" in Documentation/process/maintainer-tip.rst

>
> No functional change expected.
>
> Tested-by: Hongyu Ning <hongyu.ning@xxxxxxxxxxxxxxx>
> Signed-off-by: Chen Yu <yu.c.chen@xxxxxxxxx>

Also please follow "Ordering of commit tags" found in
Documentation/process/maintainer-tip.rst for all patches in this series.

Reinette