Re: [PATCH v5 02/10] x86/topology: Export topo_lookup_cpuid() for resctrl use

[Chen, Yu C]

Hi Reinette,

On 7/11/2026 7:35 AM, Reinette Chatre wrote:
> Hi Chenyu,
>
> Since this targets a different subsystem, could you please re-order the series
> to have this as first patch to make it obvious that it does not depend on
> anything in this series.

OK, will do.

> On 7/1/26 6:45 AM, Chen Yu wrote:
> > Make topo_lookup_cpuid() accessible outside of topology.c and add its
> > declaration to asm/apic.h. This is needed by Enhanced RDT (ERDT) to
> > resolve x2APIC IDs from ACPI tables to logical CPU numbers.
>
> The first sentence of this changelog describes verbatim what can clearly
> be seen from the patch self without any context or problem description about
> why this change is needed.
> tip changelogs always need to start with *why* the patch is needed before
> describing the change self. For more details about changelog requirements, please
> see "Changelog" in Documentation/process/maintainer-tip.rst

OK, let me revisit the commit log of this patch set to revise it.

> > No functional change expected.
> >
> > Tested-by: Hongyu Ning <hongyu.ning@xxxxxxxxxxxxxxx>
> > Signed-off-by: Chen Yu <yu.c.chen@xxxxxxxxx>
>
> Also please follow "Ordering of commit tags" found in
> Documentation/process/maintainer-tip.rst for all patches in this series.

Thank you for pointing that out; I wasn't aware. Let me rearrange the order
of this patch set.

thanks,
Chenyu