Re: [PATCH 2/2] firmware_loader: builtin: fail build on empty firmware

From: Danilo Krummrich

Date: Sat Jul 11 2026 - 19:58:34 EST


On Sun Apr 26, 2026 at 6:30 AM CEST, Dmitry Torokhov wrote:
> + if [ ! -s "$(fwdir)/$(FWNAME)" ]; then \
> + echo "error: empty firmware: $(fwdir)/$(FWNAME)" >&2 ;\
> + exit ;\

Shouldn't this be 'exit 1' to actually fail the build?

> + fi ;\