Re: [PATCH 2/2] firmware_loader: builtin: fail build on empty firmware

From: Dmitry Torokhov

Date: Sat Jul 11 2026 - 20:24:07 EST


On Sun, Jul 12, 2026 at 01:58:26AM +0200, Danilo Krummrich wrote:
> On Sun Apr 26, 2026 at 6:30 AM CEST, Dmitry Torokhov wrote:
> > + if [ ! -s "$(fwdir)/$(FWNAME)" ]; then \
> > + echo "error: empty firmware: $(fwdir)/$(FWNAME)" >&2 ;\
> > + exit ;\
>
> Shouldn't this be 'exit 1' to actually fail the build?

Yes, you are absolutely right. Do you want me to resend or you can fix
it up on your end?

Thanks.

--
Dmitry