[PATCH 2/2] HSI: omap_ssi: Remove redundant dev_err()

From: Pan Chuang

Date: Mon Jul 13 2026 - 09:35:52 EST


Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/hsi/controllers/omap_ssi_core.c | 5 +----
drivers/hsi/controllers/omap_ssi_port.c | 6 ------
2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
index eeacc427fd65..dbc4119fc305 100644
--- a/drivers/hsi/controllers/omap_ssi_core.c
+++ b/drivers/hsi/controllers/omap_ssi_core.c
@@ -370,11 +370,8 @@ static int ssi_add_controller(struct hsi_controller *ssi,
(unsigned long)ssi);
err = devm_request_irq(&ssi->device, omap_ssi->gdd_irq, ssi_gdd_isr,
0, "gdd_mpu", ssi);
- if (err < 0) {
- dev_err(&ssi->device, "Request GDD IRQ %d failed (%d)",
- omap_ssi->gdd_irq, err);
+ if (err < 0)
goto out_err;
- }

omap_ssi->port = devm_kcalloc(&ssi->device, ssi->num_ports,
sizeof(*omap_ssi->port), GFP_KERNEL);
diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c
index 98810bfd1ca8..63e8bc44630a 100644
--- a/drivers/hsi/controllers/omap_ssi_port.c
+++ b/drivers/hsi/controllers/omap_ssi_port.c
@@ -1024,9 +1024,6 @@ static int ssi_port_irq(struct hsi_port *port, struct platform_device *pd)
omap_port->irq = err;
err = devm_request_threaded_irq(&port->device, omap_port->irq, NULL,
ssi_pio_thread, IRQF_ONESHOT, "SSI PORT", port);
- if (err < 0)
- dev_err(&port->device, "Request IRQ %d failed (%d)\n",
- omap_port->irq, err);
return err;
}

@@ -1048,9 +1045,6 @@ static int ssi_wake_irq(struct hsi_port *port, struct platform_device *pd)
ssi_wake_thread,
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"SSI cawake", port);
- if (err < 0)
- dev_err(&port->device, "Request Wake in IRQ %d failed %d\n",
- cawake_irq, err);
err = enable_irq_wake(cawake_irq);
if (err < 0)
dev_err(&port->device, "Enable wake on the wakeline in irq %d failed %d\n",
--
2.34.1