[PATCH 1/2] HSI: nokia-modem: Remove redundant dev_err()
From: Pan Chuang
Date: Mon Jul 13 2026 - 09:45:25 EST
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/hsi/clients/nokia-modem.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c
index 97ba59e60663..88924d757616 100644
--- a/drivers/hsi/clients/nokia-modem.c
+++ b/drivers/hsi/clients/nokia-modem.c
@@ -157,11 +157,8 @@ static int nokia_modem_probe(struct device *dev)
do_nokia_modem_rst_ind_tasklet, (unsigned long)modem);
err = devm_request_irq(dev, irq, nokia_modem_rst_ind_isr,
pflags, "modem_rst_ind", modem);
- if (err < 0) {
- dev_err(dev, "Request rst_ind irq(%d) failed (flags %d)\n",
- irq, pflags);
+ if (err < 0)
return err;
- }
enable_irq_wake(irq);
if (pm) {
--
2.34.1