Re: [PATCH 2/3] usb: core: strengthen size check in usb_parse_interface()

[Greg Kroah-Hartman]

On Tue, Jul 14, 2026 at 08:20:32AM +0200, Oliver Neukum wrote:
> 
> 
> On 14.07.26 07:53, Greg Kroah-Hartman wrote:
> > On Mon, Jul 13, 2026 at 12:13:04PM -0400, Alan Stern wrote:
> 
> > > No, because usb_parse_configuration() has already performed this check.
> > > A malicious device can't avoid that earlier check, and so we don't need
> > > to do it again.
> > 
> > Ok, this is my fault.
> Speaking about fault here isn't likely to be productive.

But it is cathartic :)

> The error is easy to make. I made it once. We have the power
> of using comments. That place needs one.

Sure, which place, usb_parse_configuration() or the other parse
locations or both?

thanks,

greg k-h