Re: [PATCH] EDAC/mce_amd: Do not print a stray newline

[Yazen Ghannam]

On Tue, Jul 14, 2026 at 03:58:52PM +0530, Srivatsa S. Bhat wrote:
> On Mon, Jul 13, 2026 at 04:22:19PM -0700, Borislav Petkov wrote:
> > On Mon, Jul 13, 2026 at 02:44:02PM -0400, Yazen Ghannam wrote:
> > > On Sat, Jul 11, 2026 at 08:16:48PM -0700, Borislav Petkov wrote:
> > > > From: "Borislav Petkov (AMD)" <bp@xxxxxxxxx>
> > > > 
> > > > With error records which don't have FRU text, an empty newline is
> > > > printed like this:
> > > > 
> > > >   [28014.094610] mce: [Hardware Error]: Machine check events logged
> > > >   [28014.094674] [Hardware Error]: Corrected error, no action required.
> > > >   [28014.094687] [Hardware Error]: CPU:11 (19:44:1) MC0_STATUS[-|CE|MiscV|AddrV|-|-|SyndV|CECC|-|-|-]: 0x9c20400001010135
> > > >   [28014.094724] [Hardware Error]: Error Addr: 0x000000019ba9a974
> > > >   [28014.094732] [Hardware Error]: IPID: 0x001000b000000000, Syndrome: 0x000000081a1f2505
> > > > 
> > > >   [28014.094744] [Hardware Error]: Load Store Unit Ext. Error Code: 1
> > > >   [28014.094748] [Hardware Error]: cache level: L1, tx: DATA, mem-tx: DRD
> > > > 
> > > > Move the \n into the last printk() call where it belongs.
> > > > 
> > > > Signed-off-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>
> > > 
> > > Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> > 
> > Yeah, Sashiko has a point:
> > 
> > https://sashiko.dev/#/patchset/20260712031648.486110-1-bp%40kernel.org
> > 
> > So we want the error records to be compact and fit in a block so that you can
> > recognize them easier and thus not print each thing with a newline.
> > 
> > But those things are not unconditional so you cannot always know.
> > 
> > I need to think of a slick scheme what to do here.
> >
> 
> Do you mean something other than moving the newline print into an else
> block like this?
> 
> ---
>  drivers/edac/mce_amd.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
> index bd252cb3c38e..60d1a62e1a95 100644
> --- a/drivers/edac/mce_amd.c
> +++ b/drivers/edac/mce_amd.c
> @@ -870,12 +870,16 @@ amd_decode_mce(struct notifier_block *nb, unsigned long val, void *data)
>  				memcpy(&frutext[0], &err->vendor.amd.synd1, 8);
>  				memcpy(&frutext[8], &err->vendor.amd.synd2, 8);
>  
> -				pr_emerg(HW_ERR "FRU Text: %s", frutext);
> +				pr_emerg(HW_ERR "FRU Text: %s\n", frutext);
>  			}
> +		} else {
> +			/*
> +			 * Explicit line termination to handle nested
> +			 * conditional prints correctly.
> +			 */
> +			pr_cont("\n");
>  		}
>  
> -		pr_cont("\n");
> -
>  		decode_smca_error(m);
>  		goto err_code;
>  	}
> -- 

Another option could be to build up each newline string and print it
once. The gist is to get rid of pr_cont() usage.

I've attached an old patch for that. Would this work?

Thanks,
Yazen