Re: [PATCH v3 2/2] mm/mm_slot.h: add comments for mm_slot_lookup/insert
From: SJ Park
Date: Tue Jul 14 2026 - 20:25:54 EST
On Tue, 14 Jul 2026 09:28:15 +0800 (CST) <xu.xin16@xxxxxxxxxx> wrote:
> From: xu xin <xu.xin16@xxxxxxxxxx>
>
> mm_slot_lookup() and mm_slot_insert() are the only helpers in
> this header that are implemented as macros rather than static inline
> functions. This may look inconsistent without explanation.
>
> Explain they must be macros because hash_for_each_possible()
> needs the table as an array (for sizeof), not a pointer.
Thank you for adding the explanation!
>
> Signed-off-by: xu xin <xu.xin16@xxxxxxxxxx>
Reviewed-by: SJ Park <sj@xxxxxxxxxx>
Thanks,
SJ
[...]