Re: [PATCH v3 2/2] mm/mm_slot.h: add comments for mm_slot_lookup/insert

From: Zi Yan

Date: Tue Jul 14 2026 - 21:10:35 EST


On Mon Jul 13, 2026 at 9:28 PM EDT, wrote:
> From: xu xin <xu.xin16@xxxxxxxxxx>
>
> mm_slot_lookup() and mm_slot_insert() are the only helpers in
> this header that are implemented as macros rather than static inline
> functions. This may look inconsistent without explanation.
>
> Explain they must be macros because hash_for_each_possible()
> needs the table as an array (for sizeof), not a pointer.
>
> Signed-off-by: xu xin <xu.xin16@xxxxxxxxxx>
> ---
> mm/mm_slot.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
LGTM. Thanks.

Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>


--
Best Regards,
Yan, Zi