Re: [PATCH 2/2] iio: accel: mma8452: Allow open drain interrupt pin configuration

From: Andy Shevchenko

Date: Wed Jul 15 2026 - 05:14:28 EST


On Wed, Jul 15, 2026 at 10:45:42AM +0200, Joshua Crofts wrote:
> On Wed, 15 Jul 2026 10:07:39 +0200
> Esben Haabendal <esben@xxxxxxxxxx> wrote:

...

> > @@ -108,6 +110,7 @@ struct mma8452_data {
> > struct iio_mount_matrix orientation;
> > u8 ctrl_reg1;
> > u8 data_cfg;
> > + bool open_drain;
>
> Hmm, i checked pahole and it says there is a 1 byte hole, maybe try some more
> reordering to pack it?

Taking into account that the usual frames are 4 bytes and that there were
already 2 1-byte members, the place is good enough.

> > const struct mma_chip_info *chip_info;
> > int sleep_val;
> > struct regulator *vdd_reg;

--
With Best Regards,
Andy Shevchenko