Re: [PATCH v2 1/2] media: s2255: Rename CamelCase goto labels to snake_case

From: Johan Hovold

Date: Wed Jul 15 2026 - 06:01:05 EST


On Wed, Jul 15, 2026 at 05:29:46PM +0800, Lei Huang wrote:
> From: Lei Huang <huanglei@xxxxxxxxxx>
>
> Rename the error-path goto labels in s2255_probe() from CamelCase to
> snake_case to comply with the Linux kernel coding style:
>
> errorBOARDINIT -> err_boardinit
> errorFWMARKER -> err_fwmarker
> errorREQFW -> err_reqfw
> errorFWDATA2 -> err_fwdata2
> errorFWURB -> err_fwurb
> errorEP -> err_ep
> errorUDEV -> err_udev
> errorFWDATA1 -> err_fwdata1
>
> No functional changes; all label definitions and goto references are
> updated consistently.
>
> Signed-off-by: Lei Huang <huanglei@xxxxxxxxxx>

This looks ok, but the fix should go before the cleanup (e.g. to
facilitate backporting).

Also, always include a changelog (in a coverletter) when updating a
series.

Johan